Put more eyes on code

19
Put more eyes on code Dariusz Łuksza Blog: http://luksza.org Mail: [email protected]

Transcript of Put more eyes on code

Page 1: Put more eyes on code

Put more eyes on code

Dariusz ŁukszaBlog: http://luksza.orgMail: [email protected]

Page 2: Put more eyes on code

?Blog: http://luksza.orgMail: [email protected]

Page 3: Put more eyes on code

Cel!

Blog: http://luksza.orgMail: [email protected]

Autor http://www.flickr.com/photos/bogdansuditu/

Page 4: Put more eyes on code

Jak powinno wyglądać code review?

Blog: http://luksza.orgMail: [email protected]

Autor http://www.stellman-greene.com

Page 5: Put more eyes on code

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

A może tak?

Blog: http://luksza.orgMail: [email protected]

Page 6: Put more eyes on code

Raczej tak:

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

Tu powinno byćget_column()

Autor http://www.flickr.com/photos/sebastian_bergmann/

Page 7: Put more eyes on code

Ale z czego korzystać?

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

1.0

Page 8: Put more eyes on code

Ale z czego korzystać?

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

EGit

Blog: http://luksza.orgMail: [email protected]

Gerrit

Page 9: Put more eyes on code

It's a nightly build !!!

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

Znaleziono na http://vyanessa.blogspot.com/

Page 10: Put more eyes on code

Słowniczek● commit● branch● merge● rebase● fetch/pull● push● patch/change set

Blog: http://luksza.orgMail: [email protected]

Page 11: Put more eyes on code

Ale z czego korzystać?

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

Demo

Page 12: Put more eyes on code

Ale z czego korzystać?

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

2.0

Page 13: Put more eyes on code

Ale z czego korzystać?

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

Page 14: Put more eyes on code

Ale z czego korzystać?

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

Demo

Page 15: Put more eyes on code

Co zyskujemy?● Wyrównuje poziom wiedzy● Redukuje duplikację kodu● Nie psuje buildów● Podnosi jakość kodu

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

Page 16: Put more eyes on code

Co zyskujemy?● Wyrównuje poziom wiedzy● Redukuje duplikację kodu● Nie psuje buildów● Podnosi jakość kodu

● Spowalnia development● Wszystko zależy od ludzi!!

Blog: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]: http://luksza.orgMail: [email protected]

Page 17: Put more eyes on code

Wszystko zależy od ludzi

Autor http://spam.blog.com/

Blog: http://luksza.orgMail: [email protected]

Page 18: Put more eyes on code

Q&A?Blog: http://luksza.orgMail: [email protected]

Page 19: Put more eyes on code

A dokładniej ?● EGit * – http://eclipse.org/egit● Myly-reviews * – http://eclipse.org/reviews● Gerrit – http://code.google.com/p/gerrit/● Gerrit trigger – https://wiki.jenkins-ci.org/display/JENKINS/Gerrit+Trigger

● * nightly builds z http://hudson.eclipse.org/

Blog: http://luksza.orgMail: [email protected]