Code review
-
Upload
maciej-malarz -
Category
Technology
-
view
115 -
download
0
Transcript of Code review
![Page 1: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/1.jpg)
Code Review
Maciej Malarz (@malarzm)
![Page 2: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/2.jpg)
@malarzm
Maciej Malarz (@malarzm)
![Page 3: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/3.jpg)
Maciej Malarz (@malarzm)
![Page 4: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/4.jpg)
Maciej Malarz (@malarzm)
![Page 5: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/5.jpg)
Code Review
Maciej Malarz (@malarzm)
![Page 6: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/6.jpg)
Pull Requestaka
Merge Requestaka...
Maciej Malarz (@malarzm)
![Page 7: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/7.jpg)
Maciej Malarz (@malarzm)
![Page 8: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/8.jpg)
Maciej Malarz (@malarzm)
![Page 9: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/9.jpg)
Communication
Maciej Malarz (@malarzm)
![Page 10: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/10.jpg)
Maciej Malarz (@malarzm)
![Page 11: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/11.jpg)
Maciej Malarz (@malarzm)
![Page 12: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/12.jpg)
Bus Factor
Maciej Malarz (@malarzm)
![Page 13: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/13.jpg)
Maciej Malarz (@malarzm)
![Page 14: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/14.jpg)
Tech Debt
Maciej Malarz (@malarzm)
![Page 15: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/15.jpg)
Maciej Malarz (@malarzm)
![Page 16: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/16.jpg)
++Code Quality
Maciej Malarz (@malarzm)
![Page 17: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/17.jpg)
Maciej Malarz (@malarzm)
So the feature is done and working BUT I wouldn't merge my
own code so I'll refactor it first.
![Page 18: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/18.jpg)
Another pair of eyes
Maciej Malarz (@malarzm)
![Page 19: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/19.jpg)
Maciej Malarz (@malarzm)
Check Logic
![Page 20: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/20.jpg)
Maciej Malarz (@malarzm)
Proofread
![Page 21: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/21.jpg)
Maciej Malarz (@malarzm)
ProofreadCheck Logic
![Page 22: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/22.jpg)
Sharing Responsibility
Maciej Malarz (@malarzm)
![Page 23: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/23.jpg)
Maciej Malarz (@malarzm)
<alcaeus> Looks like markup is broken in the blog post<beberlei> amateurs ;)<alcaeus> hey, you merged broken stuff :P<beberlei> you +1ed it, i wouldnt do that again :P<malarzm> blargh
![Page 24: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/24.jpg)
Learning
Maciej Malarz (@malarzm)
![Page 25: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/25.jpg)
Maciej Malarz (@malarzm)
I'll merge the PR but only if you tell me what does these
things do.
![Page 26: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/26.jpg)
Proof of Concept
Maciej Malarz (@malarzm)
![Page 27: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/27.jpg)
History!
Maciej Malarz (@malarzm)
![Page 28: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/28.jpg)
Anything else?
Maciej Malarz (@malarzm)
![Page 29: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/29.jpg)
How to conduct?
Maciej Malarz (@malarzm)
![Page 30: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/30.jpg)
Reread your changes
Maciej Malarz (@malarzm)
![Page 31: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/31.jpg)
Be kind!
Maciej Malarz (@malarzm)
![Page 32: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/32.jpg)
Maciej Malarz (@malarzm)
![Page 33: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/33.jpg)
In doubt? Ask!
Maciej Malarz (@malarzm)
![Page 34: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/34.jpg)
Have better idea?Tell!
Maciej Malarz (@malarzm)
![Page 35: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/35.jpg)
GitHub goodies
Maciej Malarz (@malarzm)
![Page 36: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/36.jpg)
Maciej Malarz (@malarzm)
![Page 37: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/37.jpg)
Maciej Malarz (@malarzm)
![Page 38: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/38.jpg)
Maciej Malarz (@malarzm)
![Page 39: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/39.jpg)
Maciej Malarz (@malarzm)
![Page 40: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/40.jpg)
One true measure
Maciej Malarz (@malarzm)
![Page 41: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/41.jpg)
Maciej Malarz (@malarzm)
![Page 42: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/42.jpg)
Thank you!
Maciej Malarz (@malarzm)
![Page 43: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/43.jpg)
Questions?
Maciej Malarz (@malarzm)
![Page 44: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/44.jpg)
Thank you!
Maciej Malarz (@malarzm)
![Page 45: Code review](https://reader030.fdocuments.pl/reader030/viewer/2022020213/58ceb6401a28abb2218b5d03/html5/thumbnails/45.jpg)
Maciej Malarz (@malarzm)
http://www.animhut.com/freebies/vectors/free-vector-character-the-programmer/https://www.host.al/assets/img/avatar.pngTeam Geek by Ben Collins-Sussman, Brian W. Fitzpatrick Publisher: O'Reilly Media, Inc. Published: July 2012 Referennce ID 9781449329839http://www.furrytalk.com/tag/stuffing/http://clipartion.com/free-clipart-googly-eyes-clip-art/http://explosm.nethttp://commadot.com